teunbrand / ggh4x

ggplot extension: options for tailored facets, multiple colourscales and miscellaneous
https://teunbrand.github.io/ggh4x/
Other
564 stars 33 forks source link

Updated README: Fixed Spelling and Grammar. #32

Closed vikatti closed 3 years ago

vikatti commented 3 years ago

Hello, This is my first contribution to someone else's R package. While I have created some of my own for my organization, none of my packages are in Public domain.

Changes made:

  1. Made a sentence grammatically correct by removing an extra word.
  2. fixed spelling of a word.
  3. The images got updated when I ran the README.Rmd to create the new .md file plus some whitespace auto adjustment.

Hope you accept this change. Thanks.. Vishal Katti

teunbrand commented 3 years ago

Hello Vishal,

Thank you for finding and fixing my embarrassing mistakes! I'll have a proper look later today and probably merge this after I've incremented the package's version on github. I don't understand where the difference in whitespace is coming from. Out of curiosity: can I ask you what version of knitr and rmarkdown you've used to re-knit the readme?

Best wishes, Teun

vikatti commented 3 years ago

Apologies, i forgot to add my session info. I am R 4.0.3 with rmarkdown_2.6 and knitr_1.30

> sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252    LC_MONETARY=English_United States.1252
[4] LC_NUMERIC=C                           LC_TIME=English_United States.1252    

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] compiler_4.0.3    htmltools_0.5.1.1 tools_4.0.3       yaml_2.2.1        tinytex_0.28      rmarkdown_2.6     knitr_1.30       
 [8] digest_0.6.27     xfun_0.19         rlang_0.4.10      evaluate_0.14 
teunbrand commented 3 years ago

Yes this all looks good, thank you for fixing the mistakes!