search

teunbrand / ggh4x

ggplot extension: options for tailored facets, multiple colourscales and miscellaneous
https://teunbrand.github.io/ggh4x/
Other
541 stars 33 forks source link

ggh4x and rlang 1.0.0 #53

Closed lionel- closed 2 years ago

lionel- commented 2 years ago

Hello, I see this problem in revdep checks:

  Expected match: "The `nonsense` package is required"
  Actual message: "The package `nonsense` is required for `test`."

In general you shouldn’t be testing the contents of error messages that come from another package, since those can change at any point. Can you look into expect_snapshot() please? It allows you to monitor changes to messages without causing failures in CRAN checks. See https://testthat.r-lib.org/articles/snapshotting.html

We plan to release rlang 1.0.0 in 2 to 4 weeks.

teunbrand commented 2 years ago

Hi Lionel,

Thank you for the heads up, I'll adjust accordingly soon. I apologize if this has caused an inconvenience.

Best wishes

teunbrand commented 2 years ago

This should be updated on CRAN soon.

lionel- commented 2 years ago

Thanks!