teunbrand / ggh4x

ggplot extension: options for tailored facets, multiple colourscales and miscellaneous
https://teunbrand.github.io/ggh4x/
Other
533 stars 32 forks source link

rbind_dfs() error #81

Closed AaronMNew closed 1 year ago

AaronMNew commented 1 year ago

Hi, facet_nested() has broken for me recently. This is the error I see:

`Error in rbind_dfs(list(x[by], y[by])) : could not find function "rbind_dfs"

traceback() 13: .int$join_keys(facet_vals, layout, by = vars[vars %in% names(facet_vals)]) 12: map_data(...) 11: FUN(X[[i]], ...) 10: lapply(data[-1], self$facet$map_data, layout = self$layout, params = self$facet_params) 9: setup(..., self = self) 8: layout$setup(data, plot$data, plot$plot_env) 7: ggplot_build.ggplot(x) 6: ggplot_build(x) 5: print.ggplot(x) 4: print(x) 3: grid.draw.ggplot(plot) 2: grid.draw(plot) 1: ggsave(figure_path_0, figure.png, width = wi, height = hi) `

teunbrand commented 1 year ago

Hi there,

Could you tell me what version of ggplot2/ggh4x combination this occurs in? If this is ggplot2 3.6.0 and ggh4x 0.2.2, could I convince you to try the github version?

smouksassi commented 1 year ago

this is fixed in the dev version ggplot2 hit cran yesterday devtools::install_github("teunbrand/ggh4") works !

teunbrand commented 1 year ago

Thanks for the confirmation! I guess its time to send the dev version off to CRAN then :)

AaronMNew commented 1 year ago

devtools::install_github("teunbrand/ggh4x") Worked for me too, thank you very much (and for facet_nested as well - what an incredible function!)

snehanicholson commented 1 year ago

Hi I am having the same issue but installing from github isn't working for me

teunbrand commented 1 year ago

@snehanicholson What versions of ggh4x and ggplot2 are you using?

kotchaphorn commented 1 year ago

Hi! I am also experiencing the same issue. I have ggplot2 3.4.0 and ggh4x 0.2.3 (reinstalled just now from GitHub as suggested in this thread).

teunbrand commented 1 year ago

The recommendation to install from github was from before 0.2.3 was uploaded to CRAN. I'm having trouble getting to trigger the rbind_dfs() error from current CRAN ggplot2/ggh4x. Would anybody be able to make a minimal reproducible example for how they've triggered the bug?

This works fine for me (with current CRAN ggplot2/ggh4x):

library(ggh4x)

ggplot(mtcars, aes(mpg, wt)) +
  geom_point() +
  facet_nested(~ vs + cyl)
kotchaphorn commented 1 year ago

Hi, it works fine for me now. It seems simply reinstalling the package didn't solve the problem. I had to uninstall first, then install fresh from CRAN, both ggplot2 and ggh4x. Not sure what was going on since they were the exact same versions as before. Anyway, thank you for this wonderful package!