teunbrand / ggh4x

ggplot extension: options for tailored facets, multiple colourscales and miscellaneous
https://teunbrand.github.io/ggh4x/
Other
533 stars 32 forks source link

test-geom_text_aimed.R fails on PowerPC (Big endian) #93

Closed barracuda156 closed 1 year ago

barracuda156 commented 1 year ago
* checking tests ...
  Running ‘testthat.R’
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-geom_text_aimed.R:21'): geom_text_aimed aims text ────────────
  rotgrob$rot (`actual`) not equal to c(315, 45, 315, 45) (`expected`).

    `actual`:  NA NA  NA NA
  `expected`: 315 45 315 45
  ── Failure ('test-geom_text_aimed.R:25'): geom_text_aimed aims text ────────────
  rotgrob$rot (`actual`) not equal to c(315, 45, 135, 225) (`expected`).

    `actual`: NaN NaN NaN NaN
  `expected`: 315  45 135 225

  [ FAIL 2 | WARN 0 | SKIP 6 | PASS 796 ]
  Error: Test failures
  Execution halted
barracuda156 commented 1 year ago

R version 4.2.2 (2022-10-31) -- "Innocent and Trusting"
Copyright (C) 2022 The R Foundation for Statistical Computing
Platform: powerpc-apple-darwin10.8.0 (32-bit)

R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.

R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.

Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.

> library(testthat)
> library(ggh4x)
Loading required package: ggplot2
> 
> test_check("ggh4x")
`hclust` argument was not recognised. Switching to regular discrete scale
`hclust` argument was not recognised. Switching to regular discrete scale
`hclust` argument was not recognised. Switching to regular discrete scale
[ FAIL 2 | WARN 0 | SKIP 6 | PASS 796 ]

══ Skipped tests ═══════════════════════════════════════════════════════════════
• On CRAN (6)

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-geom_text_aimed.R:21'): geom_text_aimed aims text ────────────
rotgrob$rot (`actual`) not equal to c(315, 45, 315, 45) (`expected`).

  `actual`:  NA NA  NA NA
`expected`: 315 45 315 45
── Failure ('test-geom_text_aimed.R:25'): geom_text_aimed aims text ────────────
rotgrob$rot (`actual`) not equal to c(315, 45, 135, 225) (`expected`).

  `actual`: NaN NaN NaN NaN
`expected`: 315  45 135 225

[ FAIL 2 | WARN 0 | SKIP 6 | PASS 796 ]
Error: Test failures
Execution halted
teunbrand commented 1 year ago

Apologies for my ignorance, but what is PPC?

barracuda156 commented 1 year ago

@teunbrand Sorry, PowerPC :)

Is there anything there that could be endian-specific?

teunbrand commented 1 year ago

I apologise: I'm going to close this issue as I see no reasonable way of testing possible solutions. If you feel very invested in this issue, feel free to try out solutions on PowerPC and submit a PR if you'd like.