search

teunbrand / ggnomics

A small project to add ggplot2 extensions
https://teunbrand.github.io/ggnomics/
Other
80 stars 4 forks source link

Error in FUN(X[[i]], ...) : unused argument (env = env) #37

Closed maximilian-heeg closed 4 years ago

maximilian-heeg commented 4 years ago

Hi,

with a recent update to ggplot2, there was a change to the function eval_facets(). image

https://github.com/tidyverse/ggplot2/commit/5e6b1e5daa1599661bf5841353a067e9eee88161#diff-b8cdc3f131782de7db4bd9302d590821

The arguement env is no longer supported. This causes an error when using facet_nested(). A few changes in facet_nested.R might solve these errors:

image

Thanks for this wonderful package. Max

teunbrand commented 4 years ago

Hi Max, thanks for letting me know.

I'm reorganising this package a bit to separate out the genomics related versus not genomics related functionality so I can shamelessly gorge myself on Bioconductor dependencies in ggnomics in the future. facet_nested() and most other non-genomics functions have found a new home at the ggh4x package, which I've tested against/adjusted for ggplot v3.3.0. If you'd like to use the facet_nested() function, I recommend to use the one from the other package.

Best wishes, Teun

maximilian-heeg commented 4 years ago

Hi,

thanks for your fast answer. That totally solves my problem.

Best wishes, max