Replace unit tests for `StringTable` with tests on `Dialog`

tewtal / SMZ3Randomizer

Super Metroid & A Link to the Past Crossover Item Randomizer V11

https://samus.link/

MIT License

73 stars 32 forks source link

Replace unit tests for `StringTable` with tests on `Dialog` #160

Closed RebelusQuo closed 3 years ago

RebelusQuo commented 3 years ago

We had previously "golden standard" tests on StringTable and its entries just to have something. As the entries were changed for the "19 char" font the tests went red but were not updated. The root of this is that they are brittle so with this PR we implement the much better approach to cover the Dialog class with tests.