tewtal / SMZ3Randomizer

Super Metroid & A Link to the Past Crossover Item Randomizer V11
https://samus.link/
MIT License
74 stars 32 forks source link

Updating Normal Left Sand Pit Room requirements #168

Closed hphillips closed 2 years ago

hphillips commented 3 years ago

Power bombs cannot get you to the top of the Left Sand Pit room. So these checks either requires morph ball, spring, or VERY fast midair morphballing. The morphballing is clearly intended for Hard Mode so this change should remove the need for this on Normal. Context: I recently had a normal run where my Spring and Bombs were Flipper locked, which turned out to be in Lower Norfair which is Space Jump, and Space Jump was in the Left Sand pit room.

RebelusQuo commented 3 years ago

For the combo CanPassBombPassages is for not getting stuck and/or being able to actually grab the item when all the way inside the morph tunnel. Getting up to the tunnel, and the two tile high ledge without spring ball, so just mid air morph, is logically intended iirc.

If it's changed it should be CanIBJ || CanSpringBallJump imo, and it should also be changed for both combo and "sm only". This is ultimately a @tewtal question though.

tewtal commented 3 years ago

Currently the intended logic is to do the mid-air morphing even in normal mode, and changing that is I guess a discussion that can be had but as it is it's working "as intended". I think this is something that might get addressed in a future update where additional logic levels will be implemented.

RebelusQuo commented 3 years ago

Yes, I'm somewhat sure this was addressed in Leno's almost completed logic suggestion, but that means v12 at the earliest, right?

TarThoron commented 3 years ago

Should maybe close this PR, since the proposed change is incorrect, and is also on the SM Randomizer, not SMZ3.