search

tewtal / SMZ3Randomizer

Super Metroid & A Link to the Past Crossover Item Randomizer V11
https://samus.link/
MIT License
74 stars 32 forks source link

Add specific ped/tablet hints for each SM keycard #181

Closed dnevill closed 2 years ago

dnevill commented 2 years ago

Replaced the generic Keycard pedestal/tablet hint with specific hints for each Super Metroid keycard, and updated the Texts class to properly populate these hints.

dnevill commented 2 years ago

All the tests still pass, generated a seed with the command line tool (with temporary code to guarantee early book and a keycard on ped) and played up to checking the ped hint in snes9x-1.60-nwa-win32-x64-alpha2 to confirm the new hints get displayed without errors.

RebelusQuo commented 2 years ago

I like this. The only one I don't get is UN-B, but I think it's just a me problem, not knowing the meme. So yeah, 1 up from me!

dnevill commented 2 years ago

I like this. The only one I don't get is UN-B, but I think it's just a me problem, not knowing the meme. So yeah, 1 up from me!

Its a reference to the "Always bet on Croc" meme, TarThoron came up with the hint text so at least two of us know it, but once this change is in its exceedingly easy to alter the text for any particular keycard since it'll actually look up the text per keycard if there's a better hint text for it.

dnevill commented 2 years ago

Out of curiosity, what is the test suite? /omniflas

Oh, all the existing tests in the solution, I ran them on my build to make sure none of them failed for some reason I didn't expect (not everyone random person who sends a pull request actually runs the tests). I didn't write new tests for the Randomizer.SMZ3.Text namespace if that's what you're thinking.

RikhardHonkanen commented 2 years ago

Oh, all the existing tests in the solution, I ran them on my build to make sure none of them failed for some reason I didn't expect (not everyone random person who sends a pull request actually runs the tests). I didn't write new tests for the Randomizer.SMZ3.Text namespace if that's what you're thinking.

Thanks, dug around a bit and found them, hence deleted my original comment before I saw you replied :)

RebelusQuo commented 2 years ago

The tests should be run by everyone that contributes. They'll be run on initial/subsequent PR push by the github checks at some point.