This is my suggested implementation (to "replace" commits on master, thus conflicting) of adding bias against pendants showing up on SM bosses. It further decrease the chances around 1% compared to the current implementation on master, but these are the same ball park figures (2/3 chance of none, ~1/3 of one, rare chance of two or three).
One of the reasons for the separation of, mainly, the distributing of rewards and medallion requirements into WorldState was to have a separation of that randomization from all the details of the World. That does require assumptions about ordering, but (with our current feature set) the conceptual layout of the world is static, so it's not a stretch to assume vanilla Z3 dungeon order, followed by SM bosses in order Kraid, Phantoon, Draygon, Ridley.
I argue that any reason to map rewards against some key should be postpone to v12 since the reason and scale for such change is probably of major version size.
This is my suggested implementation (to "replace" commits on
master, thus conflicting) of adding bias against pendants showing up on SM bosses. It further decrease the chances around 1% compared to the current implementation onmaster, but these are the same ball park figures (2/3 chance of none, ~1/3 of one, rare chance of two or three).One of the reasons for the separation of, mainly, the distributing of rewards and medallion requirements into
WorldStatewas to have a separation of that randomization from all the details of theWorld. That does require assumptions about ordering, but (with our current feature set) the conceptual layout of the world is static, so it's not a stretch to assume vanilla Z3 dungeon order, followed by SM bosses in order Kraid, Phantoon, Draygon, Ridley.I argue that any reason to map rewards against some key should be postpone to v12 since the reason and scale for such change is probably of major version size.