search

tewtal / SMZ3Randomizer

Super Metroid & A Link to the Past Crossover Item Randomizer V11
https://samus.link/
MIT License
75 stars 32 forks source link

Clarify All Dungeon goal. #206

Closed TarThoron closed 1 year ago

RebelusQuo commented 2 years ago

👍 , but see review comment.

TarThoron commented 2 years ago

I don't see any review comments.

RebelusQuo commented 2 years ago

Under the "Files changed" tab in the code, or right here in the conversation under your single commit entry in the timeline.

TarThoron commented 2 years ago

Screenshot_20220726-151102 Screenshot_20220726-151029 Screenshot_20220726-151042

RebelusQuo commented 2 years ago

Giant screenshots, but ok, I think I have to assign you as reviewer which I on the other hand can not do. Thanks github. This is especially irritating since all I wanted to say, using fancy toys, was that you have a typo. It's "acquired", an extra C.

dnevill commented 2 years ago

Out of curiosity does my reviewer comment show up for you Tar or is it just Rebelus who gets to make SECRET REVIEWS?

RebelusQuo commented 2 years ago

@dnevill Thank you for providing a "unit test" awaiting the test outcome with much excitement

TarThoron commented 2 years ago

I see dnevill under Reviewers, but not the actual review under Files Changed.

Thought "aquired" looked odd, but spell check didn't flag it. Guess it's disabled in that field.

RebelusQuo commented 2 years ago

Wait.. I thought I approved the.. um.. the correct changes, not my "pointing out" review comment.. This is all very confusing.. I'm giving github a new drawing board to go back to for this one.

RebelusQuo commented 2 years ago

Never before has such a small contribution been so thoroughly reviewed as on this occasion. Good job guys!