tewtal / sm_practice_hack

Super Metroid Practice Hack
The Unlicense
27 stars 19 forks source link

Single-digit editing for word numfields #164

Closed InsaneFirebat closed 1 year ago

InsaneFirebat commented 1 year ago

Number fields that display values greater than 255/$FF can now be edited one digit at a time. It works with hex and decimal numbers. This allows the RAM Watch menu to be cut down significantly. To fill the empty space, there is a new menu item specifically for that menu that will display the values at the selected address.

There is a "bug" with decimal editing that rolls over neighboring digits when incrementing/decrementing from nine/zero. The feedback I've gotten so far is that it's either acceptable or expected.

InsaneFirebat commented 1 year ago

I think I've got this running about as well as it's going to with this method. I'm definitely happy with hex editing, but curious what others think of it for decimal.

InsaneFirebat commented 1 year ago

I've reworked editing decimal numbers so that it disassembles the value into individual digits and combines them again after modifying one. It checks against the min/max values only when exiting SDE mode and confirming the selection. All of this is to fix the rollover bug mentioned at the top.