texas-justice-initiative / website-nextjs

The website for Texas Justice Initiative
https://texasjusticeinitiative.org
GNU General Public License v2.0
7 stars 3 forks source link

Make header sticky and other minor changes #838

Closed nabroleonx closed 2 years ago

nabroleonx commented 2 years ago

This PR fixes [#839]

These are minor changes but crucial for user experience, the website's header moves up when scrolling, and users have to scroll back up to use the navigation, which isn't ideal. So I have made the header stick to the top. I also made changes to volunteer.md, the links for the tech stacks weren't working so I fixed them.

netlify[bot] commented 2 years ago

Deploy Preview for texasjusticeinitiative ready!

Name Link
Latest commit 27573a7d094ecc9a3448b8355fccbfcc0b732188
Latest deploy log https://app.netlify.com/sites/texasjusticeinitiative/deploys/63411f4e790e9d0008479687
Deploy Preview https://deploy-preview-838--texasjusticeinitiative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

nabroleonx commented 2 years ago

@LayaTaal Ok, let me fix that real quick. By the way are these pull request hacktoberfest acceptable?

nabroleonx commented 2 years ago

@LayaTaal Check it now, it is fixed. I accidentally pushed yarn.lock by mistake but I have committed a corrective commit so it should be fine. If there is anything else you come across, Let me know.

LayaTaal commented 2 years ago

@LayaTaal Ok, let me fix that real quick. By the way are these pull request hacktoberfest acceptable?

Yep, you should get credit toward Hacktoberfest for anything merged here!

nabroleonx commented 2 years ago

@LayaTaal I did what you asked. Hopefully, I did it the way you want to but if there is anything I missed, let me know and I would be happy to correct it. Can you also label hacktoberfest to this issue so my PR can count for hacktoberfest :)

nabroleonx commented 2 years ago

Can you merge the pull request if

nabroleonx commented 2 years ago

@LayaTaal Can you merge the PR if it satisfied your request.