search

texhex / BiosSledgehammer

Automated BIOS, ME, TPM firmware update and BIOS settings for HP devices
Apache License 2.0
128 stars 17 forks source link

Running BiosSledgehammer.ps1 from SCCM task sequence #79

Closed hanfelt closed 5 years ago

hanfelt commented 5 years ago

Hi there when trying to run Sledgehammer from task sequence it always fails for me. Tried making package, run command, run powershell about everything you can think of. If i hit F8 and run it manually from command i get this error: Start-TranscriptIfSupported: Cannot validate argument on parameter 'Path'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again. At MPSXM.psm1:561 char:9 Start-TranscriptIfSupported - Path $logPath -Name $logName -Ne ....

texhex commented 5 years ago

This is odd. Can you please enter the command $PSVerionTable inside a PowerShell command and post the results?

Also, just to be sure: You start this once the OS has started for the first time, not within Windows PE?

hanfelt commented 5 years ago

Yes at least i have a restart computer task that boots "The currently installed default operating system". before running the Sledgehammer script. Im running the task right now and once it fails i will post the $PSVerionTable brb.

hanfelt commented 5 years ago

PSVersion: 5.1.17134.1 PSEdition: Desktop PSComatibleVersions: 1.0 2.0 3.0 4.0 .... BuildVersion: 10.0.17134.1 CLRVersion: 4.0.30319.42000 WSManStackVersion: 3.0 PSRemotingProtocolVersion: 2.3 SerializationVersion: 1.1.0.1

hanfelt commented 5 years ago

I commented out the line 561, 565 and 713 in MPSXM.psm1

561 # Start-TranscriptIfSupported -Path $logPath -Name $logName -NewLog 565 # Start-TranscriptIfSupported -Path $logPath -Name $logName 713 # Stop-Transcript At least it runs now ;)

texhex commented 5 years ago

OK, my first guess was that in your image you used an older version of PowerShell, which is clearly not the case. Given that you are using 5.1, it is really, really strange because we had a similar bug in the past with the logging: issue #40.

I think the error starts here in the main script (line 55+):

#log the output
Start-TranscriptTaskSequence -NewLog

However, after the above mentioned bug was identified, I tried my best to work around it. Somehow this does not work for your system, so it would be great if you copy back the original MPSXM.psm1, and start the script with the verbose switch (.\BiosSledgehammer.ps1 -Verbose), and attach the output (a screenshot will do, no text file required) to this issue.

Hopefully the additional output there can help me to understand what is not working.

datagutten commented 5 years ago

I have the same problem, it can not resolve $env:TEMP, so I have set it static to c:\windows\temp

hanfelt commented 5 years ago

I will do that tomorrow at work and then post the result, thanks for all the help. Update: Sorry didnt have time to do this today had to do other stuff and had to leave early, will get back with report on monday.

texhex commented 5 years ago

Hmm, the problem with $env:TEMP again? I thought I had solved this already, but it seems not to be the case. @hanfelt After the verbose run, please also check what PS returns for $env:TEMP.

texhex commented 5 years ago

@hanfelt Any updates?

hanfelt commented 5 years ago

@texhex I tried yesterday and put the original file back but forgot to untick continue on error in the task sequence sorry ;) Then we got alot of other work to do so i couldnt continue, im off work today and might be home tomorrow as well (sick kids). I will do this first thing in the morning when im back. sorry for this delay

texhex commented 5 years ago

No problem, take your time. I just wanted to make sure this isn't stalled. All the best for your kids!

hanfelt commented 5 years ago

$env:TEMP = "C:\Windows\TEMP" 1 2

texhex commented 5 years ago

Thank you, and that's really the worst possible outcome for a log function to cause the entire script to die on the spot.

Let me check tomorrow why logPath could be empty and how to workaround it.

texhex commented 5 years ago

I updated the script and hopefully this bug is now fixed.

I have the possible explanations what is happening here:

Finally, the Start-Transscript*() functions already had verbose output to know what they are doing, but this was not used by BIOS Sledgehammer when starting it with the -Verbose parameter. This is now the case, so these function will also add verbose output.

Please do the following:

I really hope it will work this time.

texhex commented 5 years ago

@datagutten Your issue with $env:TEMP will be checked once the issue for @hanfelt is fixed. If this new version works, it would be great if you could execute it on your system and attach the verbose log to a new issue.

hanfelt commented 5 years ago

@texhex Will try this out tomorrow and get back to you with the result. Update: Had to go but my collegue said it failed. I need to run this again on thursday morning again and see if it rellay breaks at this part or if it is something else. We have had a messy week with wmi corruption around our network that we had to take care of :)

texhex commented 5 years ago

Thanks for the update and sorry to hear that it still not work. A screenshot of the lower part (below the importing functions stuff) where the "real" verbose message begin might help me to understand why it still fails.

hanfelt commented 5 years ago

Seems like it works i tried running it manually and it runs fine. It writes logs to C:\Windows\Temp as well

texhex commented 5 years ago

Very good, but when run manually, the entire code that tries to read the data from SCCM is skipped, so there might still be an issue (just saying). If possible, it would be great if you could give it a test run in SCCM, as you said it didn't run OK for your colleagues.

hanfelt commented 5 years ago

Still having to battle the other issue im really sorry for this ;) I just did i quick run today and thought it might be something else bugging out in the task sequence i did hit f8 and ran it from there and it worked. I didnt have time to do more today. Will look into this on monday next time Sorry!

texhex commented 5 years ago

No problem, thanks for the update.

hanfelt commented 5 years ago

Sorry for the late update @texhex , but i think everything works as it should, thanks alot for your help on this issue. Have a great weekend.

texhex commented 5 years ago

You are welcome, thanks for the update. Here's hope that this will be the last time we need to fix an error in logging.

I will close the issue now.