search

textadventures / quest

Create text adventure games
http://textadventures.co.uk/quest
MIT License
303 stars 70 forks source link

enter_verb pattern is set to "Regular expression", should be "Command pattern" #1121

Open KVonGit opened 3 years ago

KVonGit commented 3 years ago

I already have a pending pull request.

I would create one to fix this issue, but I don't want to get any pull requests crossed.

KVonGit commented 3 years ago

Looks like we should replace this with:

  BAD CODE REMOVED
  SEE NEXT COMMENT

https://textadventures.co.uk/forum/samples/topic/-ygnjpim-kmbpbj44zznva/attention-quest-authors-who-use-the-enter-verb#e5f4fdec-1d03-466b-92ef-74d02561113c

KVonGit commented 3 years ago

Nope. That broke a game with the existing enter_verb copied into it.

I had to change the property to "enter_verb" so it named it correctly (like the existing one).

  <verbtemplate name="enter_verb">enter</verbtemplate>
  <dynamictemplate name="DefaultEnter">WriteVerb(game.pov, "can't") + " enter " + object.article + "."</dynamictemplate>
  <verb template="enter_verb" property="enter_verb" response="DefaultEnter"/>
KVonGit commented 3 years ago

UPDATE (sort of)

I don't fully understand verbs.

See that forum thread (posted two comments ago) to see what mrangel added to the discussion. What he's saying definitely sounds right, but I still don't fully grasp everything you always wanted to know about verbs but were afraid to ask.