textadventures / quest

Create text adventure games
http://textadventures.co.uk/quest
MIT License
303 stars 70 forks source link

Missing spanish localized "go in" command #785

Closed creativo closed 9 years ago

creativo commented 9 years ago

There is a missing translated term in spanish "go" template command, and a couple terms aren't properly abbreviated.

File Core/Languages/Espanol.aslx, line: 152

<template templatetype="command" name="go"><![CDATA[^ir (a|al) (?<exit>.*)$|^ve (a|al) (?<exit>.*)$|^vaya (a|al) (?<exit>.*)$|^vete (a|al) (?<exit>.*)$|^vayase (a|al) (?<exit>.*)$|^váyase (a|al) (?<exit>.*)$|^ir (?<exit>.*)$|^(?<exit>norte|este|sur|oeste|noreste|noroeste|sureste|suroeste|entrar|salir|arriba|abajo|n|e|s|o|ne|no|se|so|sal|sube|baja)$]]></template>

Instead of:

<template templatetype="command" name="go"><![CDATA[^ir (a|al) (?<exit>.*)$|^ve (a|al) (?<exit>.*)$|^vaya (a|al) (?<exit>.*)$|^vete (a|al) (?<exit>.*)$|^vayase (a|al) (?<exit>.*)$|^váyase (a|al) (?<exit>.*)$|^ir (?<exit>.*)$|^(?<exit>norte|este|sur|oeste|noreste|noroeste|sureste|suroeste|entrar|salir|arriba|abajo|n|e|s|o|ne|no|se|so|sal|a|ab)$]]></template>

In spanish it is more common to use the term "entrar/enter(ing)" a place, that "ir adentro/go in(to)" a place; which it's simply frustrating to the player.

The expression do exists properly in the original english file:

<template name="go"><![CDATA[^go to (?<exit>.*)$|^go (?<exit>.*)$|^(?<exit>north|east|south|west|northeast|northwest|southeast|southwest|in|out|up|down|n|e|s|w|ne|nw|se|sw|o|u|d)$]]></template>

On the other hand, note that "up/u" "down/d" commands abbreviations should be replaced to "subir/a" "bajar/ab".

a: arriba abbr. ab: abajo abbr.

Commonly used in spanish games.

alexwarren commented 9 years ago

Could you send a pull request?

On 20 March 2015 at 11:50, Jannise Loire notifications@github.com wrote:

There is a missing translated term in spanish "go" template command, and a couple terms aren't properly abbreviated.

File Core/Languages/Espanol.aslx, line: 152

Instead of:

In spanish it is more common to use the term "entrar/enter(ing)" a place, that "ir adentro/go in(to)" a place; which it's simply frustrating to the player.

The expression do exists properly in the original english file:

On the other hand, note that "up/u" "down/d" commands abbreviations should be replaced to "subir/a" "bajar/ab".

a: arriba abbr. ab: abajo abbr.

Commonly used in spanish games.

— Reply to this email directly or view it on GitHub https://github.com/textadventures/quest/issues/785.

creativo commented 9 years ago

I've make a pull request, that should fix the compass problem. I would watch the Spanish library more closely. I have experience in software translation, so I'll be glad to help with that.

alexwarren commented 9 years ago

Fantastic, thanks!