search

textgrab / extension

Chrome Extension
1 stars 1 forks source link

feat: add recapture btn (fixes #36) #38

Closed sriharivishnu closed 2 years ago

sriharivishnu commented 2 years ago

Issue: #36

Menu changes opacity:

Screen Shot 2022-01-23 at 7 00 14 PM
sriharivishnu commented 2 years ago

Works as intended, very nice! No bugs were detected while testing it.

For the visual display, I would suggest shrinking the darker border around the buttons so that it takes up less space. I envision it being a pretty simple fix so will attach it onto this PR.

@mattbaseball Maybe I can decrease from bottom, left and right. If I do from all sides, that may make it more difficult to move the menu around right?

mattbaseball commented 2 years ago

Works as intended, very nice! No bugs were detected while testing it. For the visual display, I would suggest shrinking the darker border around the buttons so that it takes up less space. I envision it being a pretty simple fix so will attach it onto this PR.

@mattbaseball Maybe I can decrease from bottom, left and right. If I do from all sides, that may make it more difficult to move the menu around right?

@sriharivishnu Fair point about the other functionality of the menu being large. I think a good compromise would be to make the black background more transparent or even fully transparent when the cursor is not hovering over the menu. This would allow for a less obstructed view but also like you say, still allows for easy movement of the menu

sriharivishnu commented 2 years ago

@mattbaseball how does this look?

https://user-images.githubusercontent.com/37857112/150724088-ddbfa116-3e38-4575-b090-8268e34ad828.mov

mattbaseball commented 2 years ago

@mattbaseball how does this look?

Screen.Recording.2022-01-23.at.11.53.21.PM.mov

I like this a lot better, far less distracting!