feat: shortcut, refactor, include image + video, point + click

textgrab / extension

Chrome Extension

1 stars 1 forks source link

feat: shortcut, refactor, include image + video, point + click #6

Closed sriharivishnu closed 2 years ago

sriharivishnu commented 2 years ago

The shortcut on Mac is Option + C (on PC, would that be Alt + C ??) to activate the extension. It will use whatever object (<img> or <video>) the cursor is currently on
The labels for image are very off. Not sure why
Added a timeout (5000 milliseconds) for text to disappear

leungjch commented 2 years ago

Re: labels for images - there's a similar issue with label positioning if you scroll down on a video (so it's not completely in view)

This is what happens when I run on video thats partially out of view:

Screenshot from 2021-10-16 22-30-15

This is what the labels look like if I scroll back up (notice on the left side, the "10-15" label has been offset vertically, probably by how much I scrolled)

Screenshot from 2021-10-16 22-30-16

sriharivishnu commented 2 years ago

@leungjch to reproduce, do I scroll first and then analyze, or analyze and then scroll?

leungjch commented 2 years ago

@sriharivishnu I scrolled down, then analyzed

I think it isn't taking into account how far the user scrolled down the page, try using it on posts further down the page here: https://www.reddit.com/r/Infographics/

the labels will appear at the top of the page no matter what