textgrab / extension

Chrome Extension

1 stars 1 forks source link

fix: black background issues on dark mode #75

Closed sriharivishnu closed 2 years ago

sriharivishnu commented 2 years ago

Fixes #74

Added elements to root HTML element instead of body

sriharivishnu commented 2 years ago

After looking closely at the text displayed in #76, there is still a slight gray background on some of the text which is taken from a screenshot with a black background. However, the vast majority of text with a dark background will no longer have this issue.

Yeah it seems like this is still an issue on some sites. It will take some more investigation to narrow down the cause, but yeah I agree that it is better

sriharivishnu commented 2 years ago

I do think documentElement is better to use than body, so I will merge this since there are really no changes from the base branch