search

texthtml / oauth2-provider

OAuth2 for Symfony Security Component
GNU Affero General Public License v3.0
5 stars 2 forks source link

quite a few issues #10

Closed monbro closed 8 years ago

monbro commented 8 years ago

I have a couple off issues, starting by Pimple\ServiceProviderInterface can not be found or ControllerProviderInterface can not be found. I stopped implementing at a certain point as it was a tail of errors. I tested it on "silex/silex": "~1.3" and "texthtml/oauth2-provider": "1.5.0"

mathroc commented 8 years ago

Hi, this package is only compatible with Pimple 3. Silex 1.3 comes with an older version of Pimple so you'll need to upgrade to Silex 2 to be able to use it. I'll update the documentation to explain that

monbro commented 8 years ago

makes sense, thank you, I will give it another try as I just upgraded to silex 2.0 ;)

mathroc commented 8 years ago

ok, feel free to report other issues or difficulties you encounter, the documentation might be lacking…

monbro commented 8 years ago

also you might want to specify this in the composer requeirements, so composer will complain when installed with silex 1.3

mathroc commented 8 years ago

well, I thought about this but I'm not sure how to do that. it does not require silex (it can be used with any framework using the symfony security component) and it could even be used with silex 1.3, the TH\OAuth2\Pimple\OAuth2ServerProvider class is only here to simplify the setup when using silex 2. someone could use it with silex 1.3 by regestering manually the services & routes

monbro commented 8 years ago

I see, that correct, then my suggestion does not make any sense. Maybe you can clearify that a bit more in the docs.

mathroc commented 8 years ago

that should be better now