search

textile / php-textile

Textile markup language parser for PHP
https://textile-lang.com
Other
216 stars 44 forks source link

Suggested fix for issue #175 #176

Closed jwulfgit closed 7 years ago

jwulfgit commented 7 years ago

As described in the issue (#175), initializing $style in Parser::parseAttribsToArray as a string and then using it as an array seems to cause an error (let alone being not the best coding style I guess).

I suggest initializing and using $style only as an array and created this commit accordingly.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 97.763% when pulling 6b04b47e1f70332572fa5cffbf4b0a6feb62244c on jwulfgit:issue-175 into 4041c15781aec2b99fa9d909f7384e4427e04ee7 on textile:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 97.763% when pulling 6b04b47e1f70332572fa5cffbf4b0a6feb62244c on jwulfgit:issue-175 into 4041c15781aec2b99fa9d909f7384e4427e04ee7 on textile:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 97.763% when pulling 6b04b47e1f70332572fa5cffbf4b0a6feb62244c on jwulfgit:issue-175 into 4041c15781aec2b99fa9d909f7384e4427e04ee7 on textile:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 97.763% when pulling 6b04b47e1f70332572fa5cffbf4b0a6feb62244c on jwulfgit:issue-175 into 4041c15781aec2b99fa9d909f7384e4427e04ee7 on textile:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.002%) to 97.763% when pulling 50f95f09a87d25aefe956ee32ed1cccbf8ee1457 on jwulfgit:issue-175 into 4041c15781aec2b99fa9d909f7384e4427e04ee7 on textile:master.

ivantcholakov commented 7 years ago

Thank you, @jwulfgit, you saved my day.

fgreinus commented 7 years ago

Will this get merged?

netcarver commented 7 years ago

Thanks all, this has manually been merged into master.