search

textile / python-textile

A Python port of Textile, A humane web text generator
Other
68 stars 23 forks source link

Missing ordereddict dependency on Python 2.6 #12

Closed mblayman closed 9 years ago

mblayman commented 9 years ago

The packaging is missing ordereddict for Python 2.6. There is a Travis build for Python 2.6, but it hacks in the install of ordereddict in .travis.yml:

if [[ $TRAVIS_PYTHON_VERSION == 2.6 ]] ; then pip install ordereddict; fi

Here is an example of a tox run that doesn't include the addition above. https://travis-ci.org/handroll/handroll/jobs/37888634

I was able to fix this problem by adding ordereddict to my setup.py file, but I think python-textile should include it.

ikirudennis commented 9 years ago

In setting up travis, I didn't really explore the proper configuration and opted instead for a quick solution. It looks like I've got the proper travis config working on the develop branch (apparently travis has to be told to run python setup.py install). Give it a try, and let me know how it goes.

mblayman commented 9 years ago

Give what a try exactly? My project uses tox so it's pulling textile down from PyPI. Until a release is posted to PyPI with packaging fixes to include ordereddict, I don't think I can test anything to help out.

ikirudennis commented 9 years ago

Okay, I'm sorry I misunderstood. There should be a new version coming soon.

mblayman commented 9 years ago

No problem! Thanks for fixing it so quickly.

rczajka commented 9 years ago

The issue was that wheel format doesn't support using random code for determining conditional dependencies. Those need to be specified using explicit environment markers.