search

textile / python-textile

A Python port of Textile, A humane web text generator
Other
68 stars 23 forks source link

using sys.exectuable instead of hardcoded 'python' in test command #38

Closed arunpersaud closed 7 years ago

arunpersaud commented 7 years ago

in tests/test_cli.py line 5

'python' is used inside a command, but for python3 installation, e.g. on openSUSE, this doesn't work, since python would be the 2.7 version. Perhaps sys.executable should be used here?

I ran into this issue while trying to package textile for openSUSE as a python3 package, not sure, if this is also used in other locations.

Arun

sebix commented 7 years ago

I ran into this issue while trying to package textile for openSUSE as a python3 package

It's already there: https://build.opensuse.org/package/show/devel:languages:python3/python3-textile

ikirudennis commented 7 years ago

Is there any action required on my end? Is there anything I could or should do to simplify things?

arunpersaud commented 7 years ago

@sebix: I know;) I'm part of devel:languages:python3 and working on updating the version in dlp3 to 2.3.6. see https://build.opensuse.org/package/show/home:apersaud:branches:devel:languages:python3/python3-textile

sebix commented 7 years ago

I can push a fix, but this won't solve the problem. The textile module is not installed in standard paths in the build environment, so we can only import textile from the current directory, not the installed lib. This will work, but that's not the aim of the test.

sebix commented 7 years ago

In the build environment we can just remove this test I think.

Concerning the package for opensuse: I'm waiting for the singlespec of pytest, then I can finalize the singlespec package for textile.

ikirudennis commented 7 years ago

Thanks once again, @sebix. This will be pushed to master and released soon-ish.