Closed adam-iris closed 7 years ago
Merging #44 into develop will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## develop #44 +/- ##
======================================
Coverage 100% 100%
======================================
Files 12 12
Lines 1203 1206 +3
Branches 213 213
======================================
+ Hits 1203 1206 +3
Impacted Files | Coverage Δ | |
---|---|---|
textile/objects/block.py | 100% <ø> (ø) |
:arrow_up: |
textile/core.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a8a6a02...deca51e. Read the comment docs.
Thanks so much for this, @adam-iris.
Thanks for the quick integration and release!
These are all based on content that parsed successfully (not necessarily correctly, but without raising exceptions) in version 2.2.2, but caused problems when we moved to 2.3.11. (See the added test cases for examples of the content that was failing -- this also addresses the Unicode exception in #43, although I neglected to add a test case for that.)
I used the PHP Textile code as a guideline for these, in a lot of cases the PHP code relies on behavior that's different from Python (for example, trying to pop an item off an empty list apparently returns a null item in PHP, but raises an exception in Python). I tried to handle these in a minimal way so that the structure of the code doesn't deviate too far from the PHP version.
The one test case I'm a bit unsure about is the first one in
test_urls.py
-- if the link text starts with a space, the behavior is a bit unexpected (it quotes the whole line up to the link) but this matches the behavior of the PHP version.