textile / python-textile

A Python port of Textile, A humane web text generator
Other
68 stars 23 forks source link

Forgot to set multiline_para to False #63

Closed Igoranze closed 6 years ago

Igoranze commented 6 years ago

Hey @ikirudennis,

I am sorry for the inconvenience yet again. The multiline_para boolean that I added before needs to be closed if block.tag == 'p' is not true. Because we want to render multiline codeblock after a multiline p..

I added a test that has multiple multiline codeblocks and multiple multiline paragraphs and checked that the output is verified against txstyle.org/textile.

Added a small piece of code that sets the boolean to False if block.tag is nog p. because we only need it to work for multiline, it does not matter for single p.

Thanks a bunch!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6ce46add460876563498bfbae3937cf26b16ab7c on Igoranze:master into 51cbf11e87bca382af44632fed7d8b42cced9b05 on textile:master.

codecov-io commented 6 years ago

Codecov Report

Merging #63 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #63   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        1211   1213    +2     
  Branches      225    226    +1     
=====================================
+ Hits         1211   1213    +2
Impacted Files Coverage Δ
textile/core.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51cbf11...6ce46ad. Read the comment docs.

ikirudennis commented 6 years ago

Firstly, you are not at all an inconvenience. Finding a bug, submitting a solution with tests and maintaining 100% coverage is actually very convenient. Thank you very much, I really appreciate your contributions.

I'll release this soon. One small thing I didn't notice until now is that the names of the tests are slightly incorrect. In the github tests, I assign the test name the same number as the issue it references. I'll change the names myself, just thought I'd mention it in case you notice it when I release it.

Once again, thank you very much @Igoranze!