search

textile / python-textile

A Python port of Textile, A humane web text generator
Other
68 stars 23 forks source link

Support non-http schemas in url refs #75

Closed alts closed 3 years ago

alts commented 3 years ago

These url schemes were already valid for inline linking. This adds the ability to use them as url references as well.

codecov[bot] commented 3 years ago

Codecov Report

Merging #75 (6b787c9) into master (23e7746) will increase coverage by 1.16%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #75      +/-   ##
===========================================
+ Coverage   98.83%   100.00%   +1.16%     
===========================================
  Files          11        12       +1     
  Lines        1206      1199       -7     
  Branches      221       222       +1     
===========================================
+ Hits         1192      1199       +7     
+ Misses         14         0      -14
Impacted Files Coverage Δ
textile/core.py 100.00% <100.00%> (+1.88%) :arrow_up:
textile/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23e7746...6b787c9. Read the comment docs.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6b787c951b65b5850f598ff348ef3b5402048177 on alts:url-ref-schemas into 23e774680152bdd1e756d328dd814a096cd6b11b on textile:master.

alts commented 3 years ago

But I see, that the regular expression pattern is compiled on every function call, we can move this to the constructor, where all the other patterns are compiled as well, to gain some performance.

I'll add that change as well. Thank you.