textileio / go-threads

Server-less p2p database built on libp2p
MIT License
452 stars 65 forks source link

Support more Identity key pairs and signing algorithms #474

Open jacobcoro opened 4 years ago

jacobcoro commented 4 years ago

Add support for ID besides LibP2P for starting threads and signing. Start with for ETH wallet identities and the EIP712 signing.

The signing algorithm of choice in Ethereum is secp256k1. The hashing algorithm of choice is keccak256, this is a function from bytestrings, 𝔹⁸ⁿ, to 256-bit strings, 𝔹²⁵⁶.

Expand to bitcoin wallets second. It seems that bitcoin also uses secp256k1 what's the diff?. The difference is more about addresses than keys, so maybe they will both just work.

Can't find exactly what LibP2P is using, but dug around here and here

sanderpick commented 4 years ago

Thanks for the issue! I might be able to jump on this soon actually since the ACL work is gonna start later this week or next, and it would be great to use a couple different key types around the same ACL.