search

textileio / ios-textile

[DEPRECATED] iOS bindings for https://github.com/textileio/go-textile
MIT License
10 stars 6 forks source link

What's the right way to track down the expected signature #23

Open andrewxhill opened 5 years ago

andrewxhill commented 5 years ago

this to me

https://github.com/textileio/ios-textile/blob/master/Textile/Classes/FilesApi.m#L73

looks like it requires a threadid or sends nil? but offset it seems to force nil to a "". what is the best way to track down what happens to node with these two variables?

asutula commented 5 years ago

It sets offset to "" if nil was passed in. Otherwise it uses the passed in offset.

The whole setting nil to "" was something we thought we had to do in the past, I don't think it's actually necessary. If you look at the interface exported from Mobile.framework, it shows:

- (NSData* _Nullable)files:(NSString* _Nullable)offset limit:(long)limit threadId:(NSString* _Nullable)threadId error:(NSError* _Nullable* _Nullable)error;

offset is _Nullable which means you can pass in nil. We should update the SDK mehtod signature to be the same.