search

textileio / ios-textile

[DEPRECATED] iOS bindings for https://github.com/textileio/go-textile
MIT License
10 stars 6 forks source link

Cafe requests processing #56

Closed asutula closed 5 years ago

asutula commented 5 years ago

Have some issues the tests are highlighting we need to work out.

asutula commented 5 years ago

I get some strange errors from the go layer sometimes when I call addFiles with a Strings instance:

Error adding: proto: pb.Strings: illegal tag 0 (wire type 0)

and sometimes

Error adding: unexpected EOF

Sometimes it works fine.

asutula commented 5 years ago

Ok, want to get some eyes on this. There are a couple issues the tests are making visible we need to sort out.

(I'm registering the dev cafe)

  1. I see the NSURLSession that does uploads is getting an authentication challenge from the server, I assume, when trying to do an upload. I can't figure out why this would be.
  2. Calling Files.AddFiles fails every time with a pb error from the go layer: proto: pb.Strings: illegal tag 0 (wire type 0)
sanderpick commented 5 years ago

Okay, @asutula - handing this back over to you. Tests are passing.

sanderpick commented 5 years ago

Or rather, they are passing locally. Looks like the CI error is related to setting up a simulator. I'd say we can skip those tests in CI for now unless it's much less time consuming than getting an Android emulator going on a virtual macOS machine (the only option for emulators on CircleCI).

asutula commented 5 years ago

Tests are running on ci fine now. The previous failure was because I had created a build step that uninstalls the TestContainer app from the simulator before running the tests... That was failing on CI because the TestContainer app wasn't installed and that caused the shell script to fail.

asutula commented 5 years ago

I think this is G2G @sanderpick.

sanderpick commented 5 years ago

Android coming today...