textileio / photos

[DEPRECATED] Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos
https://www.textile.photos/
MIT License
241 stars 22 forks source link

Consolidate photo adding/viewing redux #1241

Closed asutula closed 5 years ago

asutula commented 5 years ago

Currently, we have two separate pipelines for processing camera roll photos and adding them to a thread: One for sharing a photo in a group and another for adding camera roll photos to the camera roll thread.

We also have two pipelines in place for loading thread data to view: One within the camera roll photos redux and one within the group feed redux.

With the new file sync core and sdk functionality in place, these two sets of similar pipelines are largely redundant. Also, the file sync data is architected to be useful when used in relation to the group feed redux and is hard to use from the existing camera roll photos redux.

Camera roll photos and group feeds are now the same thing from a data modeling and processing perspective, just with a different UI. This means the redux and sagas can be consolidated. This will delete a ton of code and allow us to easily implement the file sync UX/UI we want in the camera roll sync screens.