search

textileio / photos

[DEPRECATED] Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos
https://www.textile.photos/
MIT License
241 stars 22 forks source link

removed the 'add caption' view component #1295

Closed andrewxhill closed 5 years ago

andrewxhill commented 5 years ago

I was just going to change the color of an icon, but I coudn't stand looking at that super ugly comment screen anymore so got rid of it. Now it just works like this, (right to left weirdly)

Image 2

obvs can clean that up going forward, but it's better

andrewxhill commented 5 years ago

pushing this out to you guys to try... we can change anything else downstream.

sanderpick commented 5 years ago

Hmm, I think it should go into the message box like iMessage if there’s not going to be a second screen. Thinking about multi select too. You have to guess to know to remove the photo by retapping it. On Aug 8, 2019, 6:04 PM -0700, Andrew W. Hill notifications@github.com, wrote:

Merged #1295 into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

andrewxhill commented 5 years ago

100% on both. just wanted to start the progress, feels like a lot of this has been static for 6+ months.

sanderpick commented 5 years ago

Tots 👍🏼 On Aug 8, 2019, 6:45 PM -0700, Andrew W. Hill notifications@github.com, wrote:

100% on both. just wanted to start the progress, feels like a lot of this has been static for 6+ months. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

andrewxhill commented 5 years ago

it's an intermediate that is still 10x better than the add caption screen where you could optionally change which thread you wanted to add it too, that was a relic of when we had a single group feed