textileio / photos

[DEPRECATED] Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos
https://www.textile.photos/
MIT License
241 stars 22 forks source link

Full-screen image view is too sensitive to second (close) touch #1299

Open andrewxhill opened 5 years ago

andrewxhill commented 5 years ago

The full-screen view of a single shared image allows you to pan and pinch zoom an image. If you use one finger to pan the image, it will often just close it (since the view also has a 'tap to close' gesture). We need to detect longer presses and not close the view.

To create.

For me, the image will close instead of sticking to the pan.

sanderpick commented 5 years ago

Based on other app UX (insta), user feedback, and just the fact that we shouldn't be guessing how to crop people's photos, we should plan to remove the square cropping in the feed. In which case, do we still want the full-screen view?

asutula commented 5 years ago

Tough call. We should discuss. There are many questions to answer, like are we going to stick with this instgram style feed? My own opinion, non-cropped portrait photos look really bad in the instgram style feed, they're soooo tall and take up almost all the visible area of the feed. Which is why instagram makes it impossible to post a full-height portrait photo (even their portrait mode requires you crop it to not be so tall).

andrewxhill commented 5 years ago

full screen mode is even required for viewing one's own camera roll. the above problem could be fixed by adding different ways to close it or whatever, but full screen mode for a single image is required i think no matter

sanderpick commented 5 years ago

Oh right, I forgot about the gird view. 👍

undercase commented 5 years ago

We could remove the tap to close gesture and replace it with a "swipe away" gesture like on twitter's UI. I find that to be really convenient for larger screens, and it makes it easier to tell whether the user is trying to zoom or close the modal.

andrewxhill commented 5 years ago

Cool, tagging this in Sprint 19 which starts next week. We can take a look if it makes sense.