search

textileio / photos

[DEPRECATED] Encrypted, secure, decentralized personal data wallet -- technology behind textile.photos
https://www.textile.photos/
MIT License
241 stars 22 forks source link

Updates register cafe step #1313

Closed andrewxhill closed 5 years ago

andrewxhill commented 5 years ago

because cafe.url was not part of the existing Config model, I've added a method to just get it from the gateway, now just using the local config to pull in the token when needed. Will add a few comments here too.

sanderpick commented 5 years ago

I figured URL must be available since it’s displayed on the cafes screen. What does gateway mean here? The remote gateway? On Aug 21, 2019, 2:32 PM -0700, Andrew W. Hill notifications@github.com, wrote:

because cafe.url was not part of the existing Config model, I've added a method to just get it from the gateway, now just using the local config to pull in the token when needed. Will add a few comments here too. You can view, comment on, or merge this pull request online at: https://github.com/textileio/photos/pull/1313 Commit Summary

• upgrades react-native sdk, cafe reg over url, pulls urls from gateway • fixes a couple issues

File Changes

• M App/Components/CafePeerIdModal.tsx (38) • M App/Components/CafesList.tsx (34) • M App/Components/ListItem.tsx (17) • M App/Components/PhotosKeyboard.tsx (2) • M App/Containers/Cafe.tsx (18) • M App/Containers/Cafes.tsx (10) • M App/Containers/ChooseCafe.tsx (28) • M App/Containers/MailListSignupScreen.tsx (1) • M App/Containers/RegisterCafe.tsx (39) • D App/Models/cafes.ts (20) • M App/Redux/tests/ThreadsRedux.ts (2) • M App/Services/tests/Notifications.ts (4) • M App/Services/tests/PhotoUtils.ts (2) • M App/features/cafes/actions.ts (24) • M App/features/cafes/models.ts (16) • M App/features/cafes/reducer.ts (61) • M App/features/cafes/sagas.ts (197) • M App/features/cafes/selectors.ts (15) • M App/features/updates/tests/tests.ts (2) • M App/features/updates/sagas.ts (4) • M App/screens/cafe-session.tsx (1) • M App/screens/cafes.tsx (18) • M ios/Podfile.lock (18) • M ios/Pods/Local Podspecs/textile-react-native-sdk.podspec.json (6) • M ios/Pods/Manifest.lock (18) • M ios/Pods/Pods.xcodeproj/project.pbxproj (9622) • M ios/Pods/Target Support Files/FirebaseCore/FirebaseCore.xcconfig (2) • M ios/Pods/Textile/Textile/Classes/Public/CafesApi.h (6) • M ios/Pods/Textile/Textile/Classes/Public/CafesApi.m (7) • M ios/Pods/TextileCore/Mobile.framework/Versions/A/Headers/Core.objc.h (32) • M ios/Pods/TextileCore/Mobile.framework/Versions/A/Headers/Mobile.objc.h (4) • M ios/Pods/TextileCore/Mobile.framework/Versions/A/Mobile (4) • M package.json (2) • M yarn.lock (18)

Patch Links:

• https://github.com/textileio/photos/pull/1313.patch • https://github.com/textileio/photos/pull/1313.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

andrewxhill commented 5 years ago

It's known after registration via peerId. Looks like config has name, peerId, token. So, I'm just grabbing from here, https://gateway.textile.cafe/cafes, for production. For beta/dev it's known, but i still do a check to make sure it's working the same.

andrewxhill commented 5 years ago

For dev && beta, even though already known, I just do two checks to https://us-west-dev.textile.cafe and https://us-west-beta.textile.cafe

sanderpick commented 5 years ago

Can you should just change the config to include url and remove peerID? I can tell you what the URLs are. They’re also in 1Password. That gateway endpoint doesn’t contain the new production cafes. On Aug 21, 2019, 4:13 PM -0600, Andrew W. Hill notifications@github.com, wrote:

For dev && beta, even though already known, I just do two checks to https://us-west-dev.textile.cafe and https://us-west-beta.textile.cafe — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

andrewxhill commented 5 years ago

Ah, yeah, we can do that then. Will reconfig.

andrewxhill commented 5 years ago

k, that should be gtg now