textileio / storage-js

Javascript/Typescript SDK for Textile's blockchain ↔ Filecoin bridge system
MIT License
26 stars 2 forks source link

test(exports): rm status from top level exports #6

Closed andrewxhill closed 3 years ago

andrewxhill commented 3 years ago

Summary

Attempting to isolate an error happening with version 0.0.7 released.

Failed to compile.

./node_modules/@textile/eth-storage/dist/esm/index.js
Attempted import error: 'Status' is not exported from '@textile/core-storage'.

You can see the failure here https://github.com/textileio/storage-js-basic-demo/actions/runs/1118230723

It appears to come from this commit:

https://github.com/textileio/storage-js/commit/0d5a877685109386f75d9fd76121b56b3a8e73d7

andrewxhill commented 3 years ago

because Status is just a typed string, the client souldn't need to worry about the type export at all. just removing to try and clear that issue highlighted above. going to 🤠 this on passed tests since hackers are waiting for the lib and it's blocking usage.