textileio / textile

Textile hub services and buckets lib
MIT License
226 stars 45 forks source link

Old Bucket Archive Fixes #551

Closed asutula closed 3 years ago

asutula commented 3 years ago

Took over this PR to implement the actual fixes for the following issues uncovered recently:

There is one more issue I'm hoping to figure out today, old buckets not deleting, but still need more info from Cake and to do more research there. Maybe we just move forward with these current fixes for now.

asutula commented 3 years ago

Looking like this is probably not needed. Instead a data migration could be used. Will leave this open just in case, close tomorrow once we figure out a plan.

jsign commented 3 years ago

Nice, LGTM. I'm trying to remember when we nuked powergate in the hub... was that recent?

I don't recall ever nuking Powergate in any environment. I'm pretty sure that never happened since would be a bit headache regarding wallets and similars.

asutula commented 3 years ago

Yea hard to say. I don't remember specifically, but I did write code to deal with that possibility, so it must have been on our minds (see here and here). That code is basically the headache @jsign mentions... already dealt with haha.