textiles-lab / knitout-backend-kniterate

MIT License
16 stars 3 forks source link

Error for files involving decreases #13

Closed gabrielle-ohlson closed 4 years ago

gabrielle-ohlson commented 4 years ago

Here's the error that's thrown in the console:

Assertion failed: properly ordered carriage stops {
  FRNT: '...............____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________...............',
  STIF: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  REAR: '...............____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________...............',
  STIR: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  RACK: 0,
  direction: '+',
  carriageLeft: 127.5,
  carriageRight: 124.5,
  type: 'Kn-Kn',
  speed: 100,
  roller: 0,
  comment: 'automatically inserted carriage move'
}
Assertion failed: properly ordered carriage stops {
  FRNT: '...............____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________...............',
  STIF: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  REAR: '...............____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________...............',
  STIR: '000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000',
  RACK: 0,
  direction: '+',
  carriageLeft: 127.5,
  carriageRight: 124.5,
  type: 'Kn-Kn',
  speed: 100,
  roller: 0,
  comment: 'automatically inserted carriage move'
}

Output file is still created (haven't gotten a chance to properly look it over but it does seem as though there are errors)

gabrielle-ohlson commented 4 years ago

Here are some example files involving shaping that encounter this issue:

This first one includes decreases on both sides and then some short rowing at the end (dealt with in the kniterate non-fancy-takedown-mechanism-add-in-new-carriers way): small_heart_sweater.k small_heart_sweater.kc

And then this one is a hexagon (increases, then decreases): small_heart_shape.k small_heart_shape.kc

Both of them throw the error described above. I'm going to try to figure out what's going wrong this morning, but I will likely need some help navigating @ixchow 's code.

It is to be noted that my knitout for the hexagonal knit has an issue on its own accord, involving too many stitches being stacked on one needle (caused by consecutive decreases where the colorwork pattern resulted in the stacked needle not being knit after dec#1, then xfered in dec#2. Planning to fix this today)

ixchow commented 4 years ago

Removed some redundant (and un-needed) left/right stop computation in 2c27f2e -- seems to resolve this.