textiles-lab / knitout-backend-kniterate

MIT License
15 stars 4 forks source link

Waste Section in incorrect place & missing full draw thread #33

Open walpoletim-bjss opened 3 years ago

walpoletim-bjss commented 3 years ago

We have used the following process on the attached file, and end up with the attached kcode.

The waste section ends up to the right of the main knit (Rows 175 onwards) when the main knit is rows 104 to 175 and so wont properly knit

  1. Run knitout-alter-kniterate.js against original knitout file (11_3_040GarterDiamond.knitout) to create the output file (Garter.knitout)
  2. Run waste-section.js against file (Garter.knitout) to create the output file (Garter+Waste.knitout)
  3. Edit (Garter+Waste.knitout) to change carriers from ;;Carriers: 1 2 3 4 5 6 7 8 9 10 to ;;Carriers: 1 2 3 4 5 6
  4. Run knitout-to-kcode.js against file (Garter+Waste.knitout) to produce file (Garter.kc)

Files attached

Garter+Waste.knitout.txt Garter.kc.txt Garter.knitout.txt 11_3_040GarterDiamond.knitout.txt

gabrielle-ohlson commented 3 years ago

Thanks for pointing this out! I've gone ahead and added in support to knitout-alter-kniterate.js for changing the ;;Carriers: header to have the correct number of carriers for kniterate (and also changing other non-kniterate-compatible headers that may appear, such as ;;Machine: SWGN2 -> ;;Machine: Kniterate and removing unsupported extensions, such as x-presser-mode).

I definitely see the issue with Garter+Waste.knitout when looking at it in the knitout live visualizer and am about to go into the code in waste-section.js to find the bug that's causing this issue.

I'll let you know when everything is fixed and the changes have been committed!

gabrielle-ohlson commented 3 years ago

@walpoletim-bjss To make sure I am reproducing the bug correctly, would you mind listing the values you specified in response to the command line prompts when running waste-section.js?

walpoletim-bjss commented 3 years ago

Amazing - thank you so much - once we have it working will run it out on our knitereate machine.

Want to test knit swatches from here KnitDB through this convertor and then start work on our own knitouts for our business.

Do you have any knitout examples with increasing / decreasing such as for jumpers?

walpoletim-bjss commented 3 years ago

Waste section numbers I used are

ROLLER ADVANCE: 400 STITCH NUMBER: 5 SPEED NUMBER: 300 WASTE YARN CARRIER: 3 DRAW THREAD CARRIER: 1 CAST-ON STYLE: closed tube CAST-ON CARRIER: 3

gabrielle-ohlson commented 3 years ago

@walpoletim-bjss Just committed with the fixes! Let me know if there are still any problems, and if not, I'll close this issue.

Re: knitout examples with inc/dec—yes, we do. There is currently a small hexagonal sample file with some jacquard colorwork as well in the test-files folder—shape.k, but I also have some files for mini & human-sized jumpers that I can send over to you (haven't run them in a while though, so I'll need to test on the machine first). Will update you once their available!

walpoletim-bjss commented 3 years ago

Amazing thank you so much.

Looks much better - visualisation works well and kcode looks good :)

Will run it through the machine and let you know. Would love to see the jumper files as and when you have some time :):)

walpoletim-bjss commented 3 years ago

Works perfectly - Thank you :)