textlint-rule / textlint-rule-alex

textlint rule for alex
MIT License
11 stars 3 forks source link

Add support for all alex config options. #7

Closed robdodson closed 4 years ago

robdodson commented 4 years ago
robdodson commented 4 years ago

I'm not sure how the testing setup works. Perhaps it would save time for the repo owner to write the tests as they're more familiar with it?

azu commented 4 years ago

@robdodson Thanks!

I'm not sure how the testing setup works. Perhaps it would save time for the repo owner to write the tests as they're more familiar with it?

OK.

If you can, please try to add a test case in another PR 👍

It is reasonable that we add deny option to valid pattern: It test that deny option work.

        {
            text: "The boogeyman",
            options: {
                allow: ["boogeyman-boogeywoman"]
            }
        },
        {
            text: "The boogeyman",
            options: {
                // deny only "he-she" and "boogeyman" should be pass
                deny: ["he-she"]
            }
        }

https://github.com/textlint-rule/textlint-rule-alex/blob/4eccb0286bf4db6792db2662861c2d1c91740609/test/textlint-rule-alex-test.js#L12-L17

ℹ️ textlint-tester

azu commented 4 years ago

I've released v2.1.0.