search

textlint-rule / textlint-rule-ginger

textlint rule to check your English grammar with Ginger Proofreading
6 stars 3 forks source link

feat: add `skipPatterns` option #75

Closed tani closed 5 years ago

tani commented 5 years ago

Hello,

Since some jargon cannot be recognized by ginger, I added this options to skip errors. This feature has already been implemented textlint-rule-spellchecker. For me, it is enough to add this property from textlint-rule-spellchecker, however someone may want the other features. Since I have no time to do it, I stop to add the other features.

Anyway, I guess this request make your project to be better.

Thank you!

tani commented 5 years ago

Hello @azu Can you see this request? Please approve if you think no problem.

tani commented 5 years ago

@azu I change it to skipPatterns, and added test for this change.

tani commented 5 years ago

Thank you! Could you bump up the version number and upload to npm?

azu commented 5 years ago

Yes. I'll update devDeps before publishing. It will take a few minutes.

azu commented 5 years ago

Release https://github.com/textlint-rule/textlint-rule-ginger/releases/tag/2.2.0

tani commented 5 years ago

Great!