search

textlint-rule / textlint-rule-prh

textlint rule for prh.
MIT License
82 stars 6 forks source link

Add options: checkLink, checkBlockQuote, checkEmphasis, checkHeader #35

Closed Leko closed 6 years ago

Leko commented 6 years ago

Fixed #33

Leko commented 6 years ago

@azu Maybe, Image is meaningless. For example, ![ＪＱＵＥＲＹ](https://example.com) is valid always (even if checkImage is true).

Because Image has not any children of Str.

markdown: ![ＪＱＵＥＲＹ](https://example.com "ＪＱＵＥＲＹ") ast:

{
  "type": "Image",
  "title": "ＪＱＵＥＲＹ",
  "url": "https://example.com",
  "alt": "ＪＱＵＥＲＹ",
  "loc": {
    "start": {
      "line": 1,
      "column": 0
    },
    "end": {
      "line": 1,
      "column": 39
    }
  },
  "range": [
    0,
    39
  ],
  "raw": "![ＪＱＵＥＲＹ](https://example.com \"ＪＱＵＥＲＹ\")"
}

So we can remove checkImage option and Image type from the blacklist, right?

azu commented 6 years ago

@Leko You're correct. Current Image handling is incorrect.

We should file it as another issue about Image and Code support.

azu commented 6 years ago

Release https://github.com/textlint-rule/textlint-rule-prh/releases/tag/5.1.0