textlint-rule / textlint-rule-spellchecker

textlint rule to check spellings with native spellchecker
8 stars 2 forks source link

v2.2.0 doesn't recognize "skipWords" option #54

Closed yaeda closed 6 years ago

yaeda commented 6 years ago

Issue

textlint-rule-spellchecker@2.2.0 doesn't recognize "skipWords" option.

I run textlint with this .textlintrc, but got errors with "funciton" and "errror".

{
  "rules": {
    "spellchecker": {
        "skipWords": ["funciton", "errror"]
    }
  }
}

My Rough Investigation

I think the cause of this issue is in the building or publishing process.

Please install with yarn add textlint-rule-spellchecker then see/compare these two files.

lib/spellchecker.js seems to be old (no logic for skipWords option).

Environment

Thank you.

nodaguti commented 6 years ago

Thanks for the report!

Indeed the published version of textlint-rule-spellchecker doesn't seem to have been updated after changing the code in /src.

I'm in a little confusion because I surely set prepublish to transpiling the code before publishing to make sure this kind of mistake could never happen...

Anyway I've released the recompiled version as v2.2.1, so now you should be able to get the latest code.

Sorry for inconvenience!

yaeda commented 6 years ago

Thank you for re-publishing. I confirmed it works correctory 😄