search

textmate / coffee-script.tmbundle

A TextMate Bundle for CoffeeScript
MIT License
5 stars 11 forks source link

fix highlighting for division without space #2

Closed freefrancisco closed 9 years ago

freefrancisco commented 10 years ago

When writing a division without space (e.g. 4/3) the bundle thinks it is a regular expression and it highlights the rest of the code wrong. Copied what jashenkas has in his for regular expressions, fixes it for me.

infininight commented 10 years ago

This fixes the issue but goes back to the same problems that the original had. You can't match a regular expression in a single rule because there are too many different ways to escape and have characters in odd places, you can't reliably predict where it will end.

The solution will have to be one that functions on the division and looks around to see if it likely to be an expression.

Zearin commented 10 years ago

@infininight (I would have opened an issue for this, but you seem to have only Pull Requests enabled…)

This repo is marked as a fork of jashkenas/coffee-script-tmbundle. (I realize this is the official repo, and that it’s perfectly fine for official repos to fork.) I also noticed that jashkenas/coffee-script-tmbundle has also been continuously developed.

I see that as work that others have been happy to do for you!

I understand that it’s been 11 months since you forked, and that you probably don’t want to pull in 100% of the changes. If I were to clone this repo, and do the dirty work of resolving conflicts (or leaving out any commits that you don’t agree with), would you consider pulling?

The reason I ask is: there are a few small things about the the CoffeeScript bundle that have been annoying me. First, I came here to open an issue for those items. Then, I noticed that it’s been 5 months since the last commit. Since this repo is forked from jashkenas/coffee-script-tmbundle, I checked them out, and they have done a lot of (what seems to me to be) good work since you originally forked!

sorbits commented 10 years ago

I was the one who forked the bundle. I did it to improve the ⌘R experience and submitted that as a pull request: https://github.com/jashkenas/coffee-script-tmbundle/pull/122

Unfortunately they didn’t want to take that pull request because they wanted the bundle to remain compatible with TextMate 1.x and that is why the two forks diverged.

Basically we should just rebase our fork against the official one. I am not aware of stuff we do not want from that bundle — I just haven’t been involved with this bundle since I did the PR and @infininight might not have been aware of the issue I created by forking…

Zearin commented 10 years ago

Unfortunately they didn’t want to take that pull request because they wanted the bundle to remain compatible with TextMate 1.x and that is why the two forks diverged.

But…but…

…TextMate 2 is free…and better!

Stupid stupid stupid stupid stupid.

Basically we should just rebase our fork against the official one.

Think we could get a rebase going, then?

Zearin commented 10 years ago

Basically we should just rebase our fork against the official one.

Anyone up for trying?

infininight commented 10 years ago

I had done a rebase late last year, there were two new commits to pull in which I have just done.

infininight commented 9 years ago

Closing this pull request since it didn't fully correct the issue and there hasn't been any activity, open a new request if needed.