textmate / css.tmbundle

TextMate support for CSS
54 stars 36 forks source link

[css] @namespace is not syntax highlighted #24

Open aeschli opened 8 years ago

aeschli commented 8 years ago

From @dstorey on December 26, 2015 10:43

Works correctly in the parser for linting and in Intellisense, but isn't syntax highlighted as missing from css.plist

screen shot 2015-12-26 at 2 37 41 am

Syntax should be:

namespace : NAMESPACE_SYM S* [namespaceprefix S]? [STRING|URI] S_ ';' S* ; namespace_prefix : IDENT ;

My knowledge of the syntax of css.plist and regexp isn't good enough at the moment to work out how to add the optional IDENT, as there is no predefined ident like there is for strings, etc. I know how to highlight the @namespace and string component though.

I figure the IDENT should be coloured the same as @namespace as that is how the media type token is coloured for '@media media-type'

Copied from original issue: Microsoft/vscode#1659

aeschli commented 8 years ago

From @dstorey on December 26, 2015 17:18

IDENT is also needed for @keyframes, so would be good to add it in a way that can be reused, rather than defining it twice.