textmate / html.tmbundle

TextMate support for HTML
76 stars 95 forks source link

add class tag to syntax to compliment class tag #87

Closed escofield closed 6 years ago

escofield commented 6 years ago

since we have already have the Id tag syntax i would like to also add the class tag syntax. This allows for matching colors between css styling and html styling.

infininight commented 6 years ago

I'm currently got a vastly revised grammar in final testing now that will do this but on a wider scale. Every attribute will be getting a unique scope without special casing any of them. The new scopes will be:

text.html.basic meta.tag.structure.div meta.attribute.class string.quoted.double

text.html.basic meta.tag.structure.div meta.attribute.id string.quoted.double

This will work for every attribute except for custom attributes.

The only part of your patch that I don't think is a good idea if adding class items to the symbol list, would make that list too cluttered in many cases.

Going to close this since it will be superseded, thanks for the input. Look for the changes to be pushed up 4-10 days. I'll likely push them live for 2-3 days before deploying the changes to all users so if you want to test out the changes made at that time it'd be great.