textmate / rmate

Edit files from an ssh session in TextMate
http://blog.macromates.com/2011/mate-and-rmate/
513 stars 81 forks source link

Regression: rmate crashes when RemoteForward specifies an IP #21

Closed javabean closed 11 years ago

javabean commented 11 years ago

Using rmate with an ssh remote tunnel: RemoteForward 52698 127.0.0.1:52698 crashes:

$ ~/bin/rmate --version
rmate version 1.5.6 (2013-08-02)
$ ~/bin/rmate tmp/file.log
connect_to 127.0.0.1 port 52698: failed.
~/bin/rmate:153:in `readline': end of file reached (EOFError)
    from ~/bin/rmate:153:in `connect_and_handle_cmds'
    from ~/bin/rmate:192
    from ~/bin/rmate:191:in `fork'
    from ~/bin/rmate:191

(paths edited)

Workaround: use RemoteForward 52698 localhost:52698

Tested with RedHat 6 and Ubuntu 13.04

sorbits commented 11 years ago

Duplicate of #20 and explained in the release notes: https://github.com/textmate/textmate/blob/master/Applications/TextMate/about/Changes.md#2013-08-02-v20-alpha9459

On 5 Aug 2013, at 10:35, Cédrik wrote:

Using rmate with an ssh remote tunnel: RemoteForward 52698 127.0.0.1:52698 crashes:

$ ~/bin/rmate --version rmate version 1.5.6 (2013-08-02) $ ~/bin/rmate tmp/file.log connect_to 127.0.0.1 port 52698: failed. ~/bin/rmate:153:in readline': end of file reached (EOFError) from ~/bin/rmate:153:inconnect_and_handle_cmds' from ~/bin/rmate:192 from ~/bin/rmate:191:in `fork' from ~/bin/rmate:191 (paths edited)

Workaround: use RemoteForward 52698 localhost:52698

Tested with RedHat 6 and Ubuntu 13.04


Reply to this email directly or view it on GitHub: https://github.com/textmate/rmate/issues/21

markhalliwell commented 11 years ago

Please update the README to mention this "change notice". I just re-read it after this and didn't notice at the top that it does in fact show localhost. Seeing how these are usually (and often are) interchangeable, I didn't think twice that this could be the cause of it. Also it wouldn't be a bad idea to mention that the blog linked is outdated and mentions using IP address. This was a VERY annoying and made me think I the script was broken (from previous versions).

sorbits commented 11 years ago

It was mentioned in the TextMate release notes (as the sole item for the current release build): https://github.com/textmate/textmate/blob/master/Applications/TextMate/about/Changes.md#2013-08-02-v20-alpha9459

You’re of course welcome to submit a pull request for updating the README, but if people don’t read the release notes, they likely won’t come here and look for change notices.

The blog post linked has been updated to use ‘localhost’.

On Aug 18, 2013, at 6:20, Mark Carver notifications@github.com wrote:

Please update the README to mention this "change notice". I just re-read it after this and didn't notice at the top that it does in fact show localhost. Seeing how these are usually (and often are) interchangeable, I didn't think twice that this could be the cause of it. Also it wouldn't be a bad idea to mention that the blog linked is outdated and mentions using IP address. This was a VERY annoying and made me think I the script was broken (from previous versions).

— Reply to this email directly or view it on GitHub.