search

textmate / rmate

Edit files from an ssh session in TextMate
http://blog.macromates.com/2011/mate-and-rmate/
514 stars 81 forks source link

support for folder #24

Closed mjobin-mdsol closed 11 years ago

mjobin-mdsol commented 11 years ago

I realize this might be hard to implement, or maybe slow on large folder?

but being able to open a folder like I am able to with mate would be so awesome.

machine$ rmate .
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in `read': Is a directory - . (Errno::EISDIR)
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in `block in read_file'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in `open'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in `read_file'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:179:in `block in <top (required)>'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:166:in `each_index'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:166:in `<top (required)>'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/rmate:23:in `load'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/rmate:23:in `<main>'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/ruby_noexec_wrapper:14:in `eval'
    from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/ruby_noexec_wrapper:14:in `<main>'
machine$

until directories are supported, this stacktrace should be hidden, IMO

sorbits commented 11 years ago

Duplicate of #9.

Basically for folder support, TextMate would have to implement the equivalent of an sftp server and rmate would have to implement the equivalent of an sftp client.

As for hiding stack trace; blindly hiding stack trace is not good because we’re getting plenty of user problem submissions related to rmate (given it’s being run in so many different environments) and it’s easier when users can just copy/paste whatever rmate output.

But for errors we understand, presenting better errors (rather than a stack dump) would of course be preferable. My focus right now is very much on TextMate itself and writing documentation, but sometime in the future I might find time to revamp rmate, there’s a lot of potential improvements on my list, it basically needs to be rewritten with an updated protocol based on the experience we have gathered, and (better) error handling is also on this list.

On 15 Aug 2013, at 20:04, Mathieu Jobin wrote:

I realize this might be hard to implement, or maybe slow on large folder?

but being able to open a folder like I am able to with mate would be so awesome.

machine$ rmate .
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in 
`read': Is a directory - . (Errno::EISDIR)
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in 
`block in read_file'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in 
`open'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:85:in 
`read_file'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:179:in 
`block in <top (required)>'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:166:in 
`each_index'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/gems/rmate-1.5.5/bin/rmate:166:in 
`<top (required)>'
  from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/rmate:23:in `load'
  from /usr/local/rvm/gems/ruby-2.0.0-p247/bin/rmate:23:in `<main>'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/bin/ruby_noexec_wrapper:14:in 
`eval'
  from 
/usr/local/rvm/gems/ruby-2.0.0-p247/bin/ruby_noexec_wrapper:14:in 
`<main>'
machine$

until directories are supported, this stacktrace should be hidden, IMO

Reply to this email directly or view it on GitHub: https://github.com/textmate/rmate/issues/24

mjobin-mdsol commented 11 years ago

thanks for the explanation