Treat `xcrun --sdk macosx swift` as a single command

[mkhl]

When running a script containing a correct hashbang, like

#!/usr/bin/env xcrun --sdk macosx swift

the TextMate::Executor would replace the first element of command with the parsed hashbang command.

This results in TextMate trying to execute commands like

/usr/bin/env xcrun --sdk macosx swift --sdk macosx swift

which fails because swift(1) doesn’t accept an --sdk parameter.

This change specifies the whole xcrun … swift command as a single element, which it is anyway conceptually, and which fixes this problem.

[mkhl]

…of course I forgot to test on a script without shebang. Such a script results in this error:

Can't find “xcrun --sdk macosx swift” on PATH.

A workaround might be disabling hashbang parsing for Swift files, otherwise I fear this’ll require changes to TM::Executor.

• [x] Fix this for scripts without shebang lines

[mkhl]

I believe this has the same cause as #12

[mkhl]

So, the simplest thing that works: Wrap xcrun … swift in a script inside Support/bin and call that by default.

This change now works for files with and without shebangs.

[sorbits]

I fear this’ll require changes to TM::Executor

I assume you’re implying that TM::Executor would have to call shellsplit on the interpreter argument?

This is a change that I think would actually be good in general because many run commands will pass ENV['TM_«interpreter»'] to TM::Executor and here we may want the flexibility to include arguments or go via a shim.

Though it does cause an issue when there is a space in the path to the interpreter.

[jtbandes]

I assume we are talking about https://github.com/textmate/bundle-support.tmbundle/blob/master/Support/shared/lib/tm/executor.rb#L89-L91 ?

[sorbits]

@jtbandes Yes

[mkhl]

I assume you’re implying that TM::Executor would have to call shellsplit on the interpreter argument?

No, because of spaces in filenames. I was thinking about either declaring default options separately, such that they won’t duplicate options present in the shebang, or letting the first argument be an Array (like after parse_hashbang) that can be replaced wholesale.

[infininight]

I just tested the swift command and unless I'm mistaken the whole xcrun part is outdated now? Just running this in terminal works just fine:

#!/usr/bin/env swift

import Cocoa
print("Hello, world!")

So it seems that the macOS SDK is default now, at least with the latest (release not beta) version of Xcode. Not to short circuit talk of improving TM::Executor. :)

[infininight]

@mkhl I've got a commit here with a simplified Run command:

https://github.com/infininight/swift.tmbundle/commit/8545ed02b77a7fd3a9bf16b614aaceba5e9e47c5

Any problems running your code with this change?

[mkhl]

@infininight That works just fine, thanks.

If we merge that, should we update the shebang snippets to match? (To my understanding, you need to run xcrun --toolchain … swift if you have development versions of swift installed, but that’s probably too rare to affect the default snippet.)

[infininight]

Added as b3cb4372f2e63175c72eaa6e94af2eb52bb6a9db.