textmate / swift.tmbundle

TextMate support for Swift
72 stars 30 forks source link

Improve snippets #18

Closed mkhl closed 7 years ago

mkhl commented 8 years ago

This change:

jtbandes commented 8 years ago

Why do we even have snippets for Array<x> and Dictionary<x,x> when the sugared forms [x] and [x: x] are usually preferred?

mkhl commented 8 years ago

I was wondering about that myself, but felt that a larger overhaul of the snippets might be in order anyway, given time and opportunity.

infininight commented 8 years ago

Don't have any comment on the snippet themselves, but not sold on the shorter triggers, doesn't seem to follow any sort of convention based on any of the existing snippet triggers for the bundle?

jtbandes commented 8 years ago

im seems reasonable to me, but I think we should just remove the Array/Dictionary ones. shift+S+tab is nearly the same number of keystrokes as Set<, so I don't think that one's really needed either.

sorbits commented 8 years ago

+1 for just removing the Array and Dictionary snippets.

The current form makes no sense (having to type out the full word) but if we shorten the triggers, I think we should come up with a convention, e.g. the Ruby bundle limits all triggers (more or less) to the first 3 letters.

Related to the mentioned snippets, the class⇥ snippet seems either incomplete or somewhat useless, also, the common trigger for “class” is “cl⇥”.

On 12 Aug 2016, at 9:34, Jacob Bandes-Storch wrote:

im seems reasonable to me, but I think we should just remove the Array/Dictionary ones. shift+S+tab is nearly the same number of keystrokes as Set<, so I don't think that one's really needed either.

You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/textmate/swift.tmbundle/pull/18#issuecomment-239380633