textpattern / pophelp

Textpattern CMS help files.
https://textpattern.com
GNU General Public License v2.0
8 stars 6 forks source link

Tag presentation in pophelp #20

Closed petecooper closed 8 years ago

petecooper commented 8 years ago

I spotted a few @@ occurrences when hyperlink code get parsed. Example:

You will need to add the "@<txp:comments />@ tag":http://docs.textpattern.io/tags/comments manually in any article-based templates where you want comments to appear.

As RPC stuff is served up by Textpattern, the <txp:comments /> part is smushed down in the article body and @@ is outputted. Options:

Also, the hyperlink includes code-wrapped text (tag name) as well as plain text (the word 'tags'). It's a lot more straightforward to have one style of text as the hyperlink than mash two together with some Textile and some other bits

What's the preferred format for links to docs pages:

I'm a bit out of the loop on Textpattern of late, so would appreciate advice and/or clarification.

petecooper commented 8 years ago

Couple of example grabs attached. One has the tag parsed leaving just the unprocessed @ and the other doesn't process the @ or the contained tag.

safari001 safari002

petecooper commented 8 years ago

Having thought on this, the most straightforward option would be to escape the brackets with encoding.

Proposal: I'll update one of the pophelps, RPC gets updated for a sanity check, and if all good I'll process the remaining pophelps in the same fashion.

philwareham commented 8 years ago

I'm all for straightforward, so that sounds good to me - let me know when that test one is ready and I will put into RPC.

philwareham commented 8 years ago

I've tested a few methods and found one that works - please see latest 2 commits

petecooper commented 8 years ago

Neat - you beat me to it. Looks workable. So, to clarify:

philwareham commented 8 years ago

Hi,

petecooper commented 8 years ago

@philwareham I think I've snagged all the duffers and fixed them. Thanks for the RPC attention. Closing for now.