textpattern / textpacks

Textpattern CMS language files.
https://textpattern.com
GNU General Public License v2.0
23 stars 22 forks source link

More strings to add/remove #246

Closed Bloke closed 6 years ago

Bloke commented 6 years ago

Add to main Textpacks

Rename in main Textpacks

Alter in main Textpacks

Add to mode.ini

Remove

Pophelp

Tag builder new strings required

Tag builder strings to delete:

Move to [admin-side] group

Move to [common] group

Bloke commented 6 years ago

A few string changes noted in the OP regarding the tag builder. Can be done in lang-on-demand branch after the 4 remaining textpacks are regrouped (hr, nb, sr-rs, sr).

philwareham commented 6 years ago

@bloke OK, I've regrouped all the Crowdin languages now.

Looking at your requested string additions above... Does tag builder not have access to the other groups? If it does then:

  1. We already have strings thumb_height and thumb_widthwhich we could move to the admin-side (orcommon) group and make more generic height and width?
  2. We have the admin-side string parent already.
  3. We have the admin-side string skin (theme) already - can you not use that instead of a new theme string?
  4. We already have string on_front_page which we could move to the admin-side group instead of a new frontpage string?
Bloke commented 6 years ago

Thanks for doing the lang regrouping. Sterling work, Sir.

I'd like to reuse strings where we can, for sure. I did all testing in dev NOT lang-on-demand so you're right that this list may actually be out of date. Let's give lang-on-demand a final test and merge it, then worry about if there are any tag builder bits remaining. I can rejig some of the strings it uses if they're in the admin-side or common groups (provided that the AJAX call to construct the tag builder uses them - I'll check).

philwareham commented 6 years ago

Righto. The regrouped Textpacks are in lang-on-demand branch for your testing.

Bloke commented 6 years ago

Couple more amendments noted. See https://github.com/textpattern/textpattern/commit/0115b0426a97b83a1867230540a2f0f4322295fb

philwareham commented 6 years ago

Done all these. Will leave issue open for now, in case other missing strings are found.