textpattern / textpacks

Textpattern CMS language files.
https://textpattern.com
GNU General Public License v2.0
23 stars 22 forks source link

textpack_strings_installed in wrong group? #265

Closed Bloke closed 6 years ago

Bloke commented 6 years ago

It seems the textpack_strings_installed key is in the [prefs] group when it should be in [lang]. It also requires a full stop.

philwareham commented 6 years ago

Fcuks sake. OK, I'll fix this - but can you let me know f there is any decision on the 'Override' theme panel string that was discussed in forum? If I have to reconfigure Crowdin anyway, I might as well do any change to that as well, otherwise I'll need to reconfigure again. Also, web hook URLs - if I need to do a new pref text for that (i.e. so user can set a secret key/API key) I'd like to do at same time.

Bloke commented 6 years ago

Sorry.

Nobody seems to have any opinion either way on the override thing. Must just be me that thinks it's off. I can live with it.

Bloke commented 6 years ago

P.S. @philwareham Did you get my email about the Textpack on the Plugins panel? Or did the Internet eat it because of the attached code?

philwareham commented 6 years ago

Hiya, yep I got it. Will read through tomorrow and see what I can do.

FWIW I'm not keen on the 'Override' term either. Took me a while to work out what it actually did. It should be 'Rebuild' I think.

Bloke commented 6 years ago

I'm fine with 'Rebuild' if we can fashion suitable message(s) that satisfy as much of the theme/file workflow as possible. Rebuild kinda doesn't work for the 'delete' case, but as Meatloaf says, two out of three ain't bad.

philwareham commented 6 years ago

Maybe "Resynchronise' then?

Bloke commented 6 years ago

Oooh, that has merit. Me likee.

philwareham commented 6 years ago

Done. Closing.